Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configured expression resolver to default comment proccessors #89

Closed
wants to merge 1 commit into from
Closed

Add configured expression resolver to default comment proccessors #89

wants to merge 1 commit into from

Conversation

LucasJC
Copy link

@LucasJC LucasJC commented Dec 14, 2020

This version registers configured expression resolver to ParagraphRepeatProcessor and RepeatDocPartProcessor
which before defaulted to NoOpEvaluationContextConfigurer.

@antoineCharpentier-19
Copy link

antoineCharpentier-19 commented Feb 23, 2021 •
edited
Loading

Please merge this pr.
We need it for HashMap based contexts and have resorted to reflection to set the resolvers in the meantime, which really sucks.

@thombergs
Copy link
Owner

thombergs commented Aug 1, 2023 •
edited
Loading

thanks for the contribution! I already merged in #92, which contains this change, though.

@thombergs thombergs closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasJC @antoineCharpentier-19 @thombergs