Skip to content

Conversation

@thorek1
Copy link
Owner

@thorek1 thorek1 commented Jun 25, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2025

Codecov Report

❌ Patch coverage is 76.90355% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.71%. Comparing base (895d027) to head (ee6ce4b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/MacroModelling.jl 73.78% 81 Missing ⚠️
src/get_functions.jl 89.09% 6 Missing ⚠️
src/filter/inversion.jl 77.77% 2 Missing ⚠️
src/macros.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   82.43%   88.71%   +6.27%     
==========================================
  Files          18       19       +1     
  Lines       10625    12367    +1742     
==========================================
+ Hits         8759    10971    +2212     
+ Misses       1866     1396     -470     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jun 25, 2025

Benchmark Results

main 40a5408... main / 40a5408...
FS2000/NSSS 13.8 ± 0.44 μs 13.7 ± 0.45 μs 1.01 ± 0.046
FS2000/covariance 0.117 ± 0.0026 ms 0.117 ± 0.0033 ms 1 ± 0.036
FS2000/irf 0.998 ± 0.05 ms 0.993 ± 0.043 ms 1 ± 0.066
FS2000/jacobian 0.77 ± 0.003 μs 0.77 ± 0.0039 μs 1 ± 0.0064
FS2000/lyapunov/bartels_stewart 0.104 ± 0.00098 ms 0.101 ± 0.00087 ms 1.02 ± 0.013
FS2000/lyapunov/bicgstab 0.0439 ± 0.0013 ms 31.1 ± 15 μs 1.41 ± 0.67
FS2000/lyapunov/doubling 0.0517 ± 0.015 ms 0.0513 ± 0.015 ms 1.01 ± 0.41
FS2000/lyapunov/gmres 26.6 ± 1.8 μs 26.4 ± 1.8 μs 1.01 ± 0.096
FS2000/qme/doubling 0.122 ± 0.0099 ms 0.121 ± 0.0025 ms 1.01 ± 0.084
FS2000/qme/schur 0.0702 ± 0.017 ms 0.0822 ± 0.017 ms 0.854 ± 0.27
NAWM_EAUS_2008/NSSS 2.86 ± 0.045 ms 2.52 ± 0.038 ms 1.13 ± 0.025
NAWM_EAUS_2008/covariance 25 ± 0.13 ms 24.9 ± 0.43 ms 1.01 ± 0.018
NAWM_EAUS_2008/irf 26.7 ± 0.36 ms 26.7 ± 0.45 ms 1 ± 0.022
NAWM_EAUS_2008/jacobian 0.0539 ± 0.011 ms 0.061 ± 0.006 ms 0.884 ± 0.2
NAWM_EAUS_2008/lyapunov/bartels_stewart 28.8 ± 0.54 ms 28.5 ± 0.57 ms 1.01 ± 0.028
NAWM_EAUS_2008/lyapunov/bicgstab 0.236 ± 0.012 s 0.302 ± 0.022 s 0.781 ± 0.068
NAWM_EAUS_2008/lyapunov/doubling 16.7 ± 0.45 ms 16.7 ± 0.46 ms 1 ± 0.039
NAWM_EAUS_2008/lyapunov/gmres 0.137 ± 0.0013 s 0.138 ± 0.00069 s 0.991 ± 0.01
NAWM_EAUS_2008/qme/doubling 23 ± 0.86 ms 22.8 ± 0.71 ms 1 ± 0.049
NAWM_EAUS_2008/qme/schur 15.8 ± 0.49 ms 15.6 ± 0.47 ms 1.01 ± 0.044
Smets_Wouters_2007/NSSS 0.147 ± 0.011 ms 0.154 ± 0.012 ms 0.957 ± 0.1
Smets_Wouters_2007/covariance 1.6 ± 0.033 ms 1.61 ± 0.043 ms 0.993 ± 0.033
Smets_Wouters_2007/irf 5.43 ± 0.22 ms 5.47 ± 0.22 ms 0.993 ± 0.057
Smets_Wouters_2007/jacobian 9.62 ± 2.5 μs 10.6 ± 22 μs 0.909 ± 1.9
Smets_Wouters_2007/lyapunov/bartels_stewart 1.52 ± 0.012 ms 1.48 ± 0.011 ms 1.03 ± 0.011
Smets_Wouters_2007/lyapunov/bicgstab 6.04 ± 0.032 ms 6.24 ± 0.032 ms 0.968 ± 0.0072
Smets_Wouters_2007/lyapunov/doubling 0.954 ± 0.0079 ms 0.957 ± 0.0084 ms 0.997 ± 0.012
Smets_Wouters_2007/lyapunov/gmres 6.74 ± 0.42 ms 6.81 ± 0.46 ms 0.99 ± 0.091
Smets_Wouters_2007/qme/doubling 1.74 ± 0.03 ms 1.75 ± 0.025 ms 0.994 ± 0.022
Smets_Wouters_2007/qme/schur 1.28 ± 0.028 ms 1.21 ± 0.02 ms 1.06 ± 0.029
time_to_load 8.2 ± 0.032 s 8.24 ± 0.0075 s 0.995 ± 0.004
main 40a5408... main / 40a5408...
FS2000/NSSS 0.357 k allocs: 18.8 kB 0.357 k allocs: 18.8 kB 1
FS2000/covariance 1.06 k allocs: 0.13 MB 1.06 k allocs: 0.13 MB 0.999
FS2000/irf 6.98 k allocs: 0.335 MB 6.98 k allocs: 0.335 MB 1
FS2000/jacobian 1 allocs: 16 B 1 allocs: 16 B 1
FS2000/lyapunov/bartels_stewart 0.074 k allocs: 0.0656 MB 0.074 k allocs: 0.0656 MB 1
FS2000/lyapunov/bicgstab 0.087 k allocs: 0.0377 MB 0.087 k allocs: 0.0377 MB 1
FS2000/lyapunov/doubling 0.063 k allocs: 0.0393 MB 0.063 k allocs: 0.0393 MB 1
FS2000/lyapunov/gmres 0.145 k allocs: 0.0815 MB 0.145 k allocs: 0.0815 MB 1
FS2000/qme/doubling 0.2 k allocs: 0.0431 MB 0.2 k allocs: 0.0431 MB 1
FS2000/qme/schur 0.266 k allocs: 0.0842 MB 0.266 k allocs: 0.0842 MB 1
NAWM_EAUS_2008/NSSS 1.68 k allocs: 1.58 MB 1.62 k allocs: 1.4 MB 1.13
NAWM_EAUS_2008/covariance 4.25 k allocs: 15.5 MB 4.2 k allocs: 15.4 MB 1.01
NAWM_EAUS_2008/irf 0.101 M allocs: 16.4 MB 0.101 M allocs: 16.2 MB 1.01
NAWM_EAUS_2008/jacobian 7 allocs: 0.709 MB 7 allocs: 0.709 MB 1
NAWM_EAUS_2008/lyapunov/bartels_stewart 0.173 k allocs: 4.92 MB 0.181 k allocs: 4.92 MB 1
NAWM_EAUS_2008/lyapunov/bicgstab 0.09 k allocs: 5.66 MB 0.09 k allocs: 5.66 MB 1
NAWM_EAUS_2008/lyapunov/doubling 0.07 k allocs: 6.87 MB 0.07 k allocs: 6.87 MB 1
NAWM_EAUS_2008/lyapunov/gmres 0.39 k allocs: 0.0411 GB 0.39 k allocs: 0.0411 GB 1
NAWM_EAUS_2008/qme/doubling 0.309 k allocs: 6.29 MB 0.309 k allocs: 6.29 MB 1
NAWM_EAUS_2008/qme/schur 0.419 k allocs: 7.41 MB 0.419 k allocs: 7.41 MB 1
Smets_Wouters_2007/NSSS 1.22 k allocs: 0.0581 MB 1.22 k allocs: 0.0582 MB 0.999
Smets_Wouters_2007/covariance 3.03 k allocs: 1.34 MB 3.03 k allocs: 1.34 MB 1
Smets_Wouters_2007/irf 0.0331 M allocs: 2.19 MB 0.0331 M allocs: 2.2 MB 0.999
Smets_Wouters_2007/jacobian 7 allocs: 0.0612 MB 7 allocs: 0.0612 MB 1
Smets_Wouters_2007/lyapunov/bartels_stewart 0.084 k allocs: 0.441 MB 0.088 k allocs: 0.441 MB 1
Smets_Wouters_2007/lyapunov/bicgstab 0.089 k allocs: 0.469 MB 0.089 k allocs: 0.469 MB 1
Smets_Wouters_2007/lyapunov/doubling 0.069 k allocs: 0.568 MB 0.069 k allocs: 0.568 MB 1
Smets_Wouters_2007/lyapunov/gmres 0.301 k allocs: 2.65 MB 0.301 k allocs: 2.65 MB 1
Smets_Wouters_2007/qme/doubling 0.3 k allocs: 0.623 MB 0.3 k allocs: 0.623 MB 1
Smets_Wouters_2007/qme/schur 0.403 k allocs: 0.756 MB 0.403 k allocs: 0.756 MB 1
time_to_load 0.143 k allocs: 10.6 kB 0.153 k allocs: 11 kB 0.962

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Thore Kockerols and others added 30 commits October 6, 2025 13:05
…152)

* Initial plan

* Add plotting.md documentation and generate_plots.jl script

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Add plotting documentation references to docstrings

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Add README for plot generation and note to plotting_script.jl

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Remove plotting documentation references

Removed references to comprehensive plotting documentation in multiple sections.

* Remove SAVE_PLOTS_NAME constant

Removed the SAVE_PLOTS_NAME constant from common docstrings.

* Delete docs/README_plots.md

* Fix plot filename references to match automatic naming convention

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
Co-authored-by: Thore Kockerols <thorek1@users.noreply.github.com>
Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
…ing impulse response function plots and saving them to the documentation assets directory. This script was previously used to facilitate the regeneration of documentation plots.
…on! for combining multiple solutions (#153)

* Initial plan

* Refactor plot_solution to accept single algorithm and add plot_solution!

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Update tests for new plot_solution API

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Remove duplicate include of default_options.jl in MacroModelling.jl

* Add relevant input differences table to plot_solution! for comparing multiple solutions

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Fix plot_solution to handle single container case on first call

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Implement legend with 2 columns and show relevant input difference for single difference case

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* Add support for multiple states with separate plot sets per state

Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>

* order of legend items

* Adjust layout heights in _plot_solution_from_container to accommodate varying input differences

* fix plot solution

* Enhance functionality tests by adding comprehensive plot_solution! tests for multiple algorithms and states

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thorek1 <13523097+thorek1@users.noreply.github.com>
Co-authored-by: thorek1 <thorek1@users.noreply.github.com>
Co-authored-by: Thore Kockerols <Thore.Kockerols@ecb.europa.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants