Typos and stuff I thought I'd clean up while following Part I#2
Typos and stuff I thought I'd clean up while following Part I#2r4dian wants to merge 16 commits intothormagnusson:masterfrom
Conversation
Gitbook disxussion link has been subject to bitrot, changed it to github issues.
(and these single ones ‘ ’ with ')
This makes it easier to find & replace characters like the problem quotes. Added a coupld of TODO notes where some of the text seems wrong, but I don't don't understand enough to fix it yet.
It didn't work before & this is more equivalant of the lists example it's contrasted with.
That's your external ip, but you want your machines ip on your network, not on the wider internet. (Unless you want to also get into port forwarding and router config here...) 127.0.0.1, the loopback address, will do for this example. In case anyone asks: On Windows, get it from `gip` or `Get-NetIPConfiguration` in Powershell On macOS/Linux you can find it in ifconfig as the most cross-platform way for all distros.
If the sine goes from -1 to 1, then -1+2=1 to 1+2=3 times 220 is 220 to 660, not 440 to 660.
Added some Windows shortcuts, and some emphasis, Fixed a typo, Removed one example that was repeated twice exactly the same, ... etc.
Couple of typos in the identifiers of synthdefs. linebreaks in "> quote boxes" were broken
|
hi @thormagnusson, would you be interested in corrections like these? i'm currently reading the book, and i find it immensely helpful. there are examples of minor typos, mismatched strings in examples, links that are not marked up correctly and other errata like that. i'd gladly provide additional corrections while going through the book if this is desired. |
|
Hi both, yes, it would be very good to get these corrections. I have very little time to spare, but this kind of suggestions would be very helpful! |
|
This pull request is already quite comprehensive and covers most of what I find as I read. There are some really minor bits that I have corrected so far. This repository doesn't contain the latest version of the book, right? I noticed that the "GUI" section in part I chapter 4 is missing. |
|
Hi, I think we talked about this on Facebook or elsewhere when I opened the PR. If there's a up to date repo hosted elsewhere, I can apply the same changes there. Or if you push the latest version here, we can see if the PR has conflicts or just works. |
3 participants
Decided to learn SC properly instead of just editing examples without full understanding, and found this book on gitbooks.
Some examples were broken, mostly by "" and '' gettign formatted as “” and ‘ ’ and so on.