Skip to content

gl: GL canvas targeting across SDL platforms (macOS/EGL/Win32/X11) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wenjieshen wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

gl: GL canvas targeting across SDL platforms (macOS/EGL/Win32/X11) #10

wenjieshen wants to merge 1 commit into from
+190 −12

Conversation

@wenjieshen
Copy link
Collaborator

@wenjieshen wenjieshen commented Jan 5, 2026 •
edited
Loading

  • Updates GL examples to call SDL_GL_MakeCurrent() and provide the correct native handles to tvg::GlCanvas::target() on macOS (CGL), GLES (EGL), Windows (HDC/HWND), and X11 (Display/Window), with a safe fallback.
  • Ensures GL raster support is enabled at build time when gl or glesv2 is found; enables the GLES path via TVGEXAMPLE_GLES_SUPPORTED.
  • Aims to prevent incorrect/blank rendering caused by targeting the canvas with insufficient context info.

** Please ensure that this pull request is merged only after the following one is approved and merged: thorvg/thorvg#4065. **

@wenjieshen wenjieshen requested a review from hermet as a code owner January 5, 2026 19:47
@wenjieshen wenjieshen marked this pull request as draft January 5, 2026 19:49
@hermet hermet added the enhancement Improve examples label Jan 6, 2026
@hermet hermet mentioned this pull request Jan 7, 2026
Merged
@wenjieshen
[NOT FOR MERGE] Combine GL context example and platform cleanup
4781749 
- Add context example to verify GL context switching
- Remove support for macOS and X11
- Normalize EXAMPLE_DIR on Windows for Meson example build

[NOT FOR MERGE] Add Meson GL backend option

Introduce meson_options.txt to select GL vs GLES.
Wire option in examples build to pull gl/gles+egl deps and
set TVGEXAMPLE_GLES_SUPPORTED for GLES builds. Update GL
context setup to use the new GLES define and prioritize EGL
context handling when enabled.
@wenjieshen wenjieshen force-pushed the jay/gl/multi-context-support branch from a17c3fb to 4781749 Compare January 7, 2026 15:33
@hermet
Copy link
Member

hermet commented Jan 7, 2026 •
edited
Loading

@wenjieshen We might need to upgrade to SDL3 first. Until that, we could pass nullptr...

SDL_EGLDisplay display = SDL_EGL_GetCurrentDisplay();
 // sdl is running on egl.
if (display) {
   //get surface
}

https://wiki.libsdl.org/SDL3/SDL_EGL_GetCurrentDisplay
https://wiki.libsdl.org/SDL3/SDL_EGL_GetWindowSurface

@hermet
Copy link
Member

hermet commented Jan 8, 2026

#13

@hermet hermet mentioned this pull request Jan 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermet hermet Awaiting requested review from hermet hermet is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@wenjieshen wenjieshen

Labels

enhancement Improve examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wenjieshen @hermet