Skip to content

switch sdl2 to sdl3 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vtorri wants to merge 2 commits into
base: main
Choose a base branch
from
Open

switch sdl2 to sdl3 #16

vtorri wants to merge 2 commits into from

Conversation

@vtorri
Copy link

@vtorri vtorri commented Jan 9, 2026

No description provided.

@vtorri vtorri requested a review from hermet as a code owner January 9, 2026 22:32
@vtorri vtorri mentioned this pull request Jan 9, 2026
Open
hermet
hermet requested changes Jan 11, 2026
View reviewed changes
src/Example.h
#include <thorvg-1/thorvg.h>
#include <SDL2/SDL.h>
#include <SDL2/SDL_syswm.h>
#include <thorvg.h>
Copy link
Member

@hermet hermet Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be changed.

src/LottieExtension.cpp
*/

#include <thorvg-1/thorvg_lottie.h>
#include <thorvg_lottie.h>
Copy link
Member

@hermet hermet Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be changed

src/LottieTweening.cpp
*/

#include <thorvg-1/thorvg_lottie.h>
#include <thorvg_lottie.h>
Copy link
Member

@hermet hermet Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not change

@hermet hermet added the infrastructure Dev infrastructure label Jan 11, 2026
@vtorri
Copy link
Author

vtorri commented Jan 12, 2026

@hermet

$ pkgconf --cflags thorvg-1
-IC:/Documents/msys2_2/opt/thorvg/include/thorvg-1 -IC:/Documents/msys2_2/home/vincent.torri/ewpi_64/include/libpng16 -IC:/Documents/msys2_2/home/vincent.torri/
ewpi_64/include -IC:/Documents/msys2_2/ucrt64/bin/../include -IC:/Documents/msys2_2/home/vincent.torri/ewpi_64/include/webp

including thorvg-1/thorvg.h is not possible, hence my change, to at least compile

@hermet
Copy link
Member

hermet commented Jan 13, 2026

@vtorri I think it's a different story, you don't need to touch it in this PR.

@hermet hermet mentioned this pull request Jan 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermet hermet hermet requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@vtorri vtorri

Labels

infrastructure Dev infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtorri @hermet