-
-
Notifications
You must be signed in to change notification settings - Fork 1
updated push() -> add() calls according to the recent api changes #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the ThorVG Example codebase to reflect recent API changes in the ThorVG library, specifically replacing push() method calls with add() method calls across all example files. The changes also update the SceneEffect::ClearAll enum value to SceneEffect::Clear and update related comments to reflect the new terminology.
Changes:
- Updated all
canvas->push(),scene->push(), andmask->push()calls to useadd()method - Changed
SceneEffect::ClearAlltoSceneEffect::Clearin effect-related examples - Updated comments referencing "push" to use "add" terminology instead
Reviewed changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Viewport.cpp | Updated canvas->push() to canvas->add() for picture object |
| src/TrimPath.cpp | Updated canvas->push() to canvas->add() for shape objects |
| src/Transform.cpp | Updated canvas->push() to canvas->add() for multiple shape transformations |
| src/TextLineWrap.cpp | Updated canvas->push() to canvas->add() for text and shape objects |
| src/TextLayout.cpp | Updated canvas->push() to canvas->add() for text layout examples |
| src/TextEffects.cpp | Updated canvas->push() to canvas->add() for animated text effects |
| src/Text.cpp | Updated canvas->push() to canvas->add() for various text rendering examples |
| src/Svg.cpp | Updated canvas->push() to canvas->add() and updated comments about asynchronous loading |
| src/StrokeMiterlimit.cpp | Updated canvas->push() to canvas->add() for stroke examples |
| src/StrokeLine.cpp | Updated canvas->push() to canvas->add() for stroke line examples |
| src/Stroke.cpp | Updated canvas->push() to canvas->add() for stroke rendering |
| src/Stress.cpp | Updated canvas->push() to canvas->add() in stress test |
| src/Shapes.cpp | Updated canvas->push() to canvas->add() for basic shape rendering |
| src/SceneTransform.cpp | Updated scene->push() and canvas->push() to add(), updated comments |
| src/SceneEffects.cpp | Updated scene->push() and canvas->push() to add(), changed ClearAll to Clear |
| src/SceneBlending.cpp | Updated scene->push() and canvas->push() to add() for blending examples |
| src/Scene.cpp | Updated scene->push() and canvas->push() to add(), updated comments |
| src/Retaining.cpp | Updated canvas->push() to canvas->add(), updated comment about re-adding paints |
| src/RadialGradient.cpp | Updated canvas->push() to canvas->add() for gradient shapes |
| src/PictureWebp.cpp | Updated canvas->push() to canvas->add() for WebP images |
| src/PictureSvg.cpp | Updated canvas->push() to canvas->add() for SVG pictures |
| src/PictureRaw.cpp | Updated canvas->push() to canvas->add() for raw image data |
| src/PicturePng.cpp | Updated canvas->push() to canvas->add() for PNG images |
| src/PictureJpg.cpp | Updated canvas->push() to canvas->add() for JPEG images |
| src/Path.cpp | Updated canvas->push() to canvas->add() for path rendering |
| src/Particles.cpp | Updated canvas->push() to canvas->add() for particle effects |
| src/Opacity.cpp | Updated scene->push() and canvas->push() to add() for opacity examples |
| src/MultiCanvas.cpp | Updated canvas->push() to canvas->add() in multi-canvas example |
| src/MaskingMethods.cpp | Updated canvas->push() to canvas->add() for various masking methods |
| src/Masking.cpp | Updated canvas->push() to canvas->add() for masking examples |
| src/LumaMasking.cpp | Updated canvas->push(), scene->push(), and mask->push() to add() |
| src/LottieTweening.cpp | Updated canvas->push() to canvas->add() for Lottie animations |
| src/LottieInteraction.cpp | Updated canvas->push() to canvas->add() with std::move |
| src/LottieExtension.cpp | Updated canvas->push() to canvas->add() for Lottie extensions |
| src/LottieExpressions.cpp | Updated canvas->push() to canvas->add() for Lottie expressions |
| src/Lottie.cpp | Updated canvas->push() to canvas->add() for Lottie animations |
| src/LinearGradient.cpp | Updated canvas->push() to canvas->add() for linear gradients |
| src/Intersects.cpp | Updated canvas->push() to canvas->add() for intersection testing |
| src/ImageScaling.cpp | Updated canvas->push() to canvas->add() for image scaling |
| src/ImageRotation.cpp | Updated canvas->push() to canvas->add() for image rotation |
| src/GradientTransform.cpp | Updated canvas->push() to canvas->add() for gradient transformations |
| src/GradientStroke.cpp | Updated canvas->push() to canvas->add() for gradient strokes |
| src/GradientMasking.cpp | Updated canvas->push() to canvas->add() for gradient masking |
| src/FillSpread.cpp | Updated canvas->push() to canvas->add() for fill spread modes |
| src/FillRule.cpp | Updated canvas->push() to canvas->add() for fill rules |
| src/EffectDropShadow.cpp | Updated scene->push() and canvas->push() to add(), changed ClearAll to Clear |
| src/Duplicate.cpp | Updated canvas->push() and scene->push() to add() for duplication examples |
| src/DirectUpdate.cpp | Updated canvas->push() to canvas->add() for direct updates |
| src/DataLoad.cpp | Updated canvas->push() to canvas->add() for data loading |
| src/CustomTransform.cpp | Updated canvas->push() to canvas->add() for custom transformations |
| src/Clipping.cpp | Updated scene->push() and canvas->push() to add() for clipping |
| src/BoundingBox.cpp | Updated canvas->push() and scene->push() to add() for bounding box examples |
| src/Blending.cpp | Updated canvas->push() to canvas->add() for blending modes |
| src/Animation.cpp | Updated canvas->push() to canvas->add() for animations |
| src/Accessor.cpp | Updated canvas->push() to canvas->add() for accessor example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- this example is enabled at compilation if the system has thorvg_capi - revised the lottie compilation with more precise symbol check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 57 out of 57 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.