example: request stencil + MSAA buffers for GL contexts #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermet
force-pushed
the
main
branch
6 times, most recently
from
5cbf5cf to
f5bcc97
Compare
wenjieshen
force-pushed
the
jay/gl-direct-backbuffer-example
branch
from
a8cff02 to
137ff20
Compare
wenjieshen
force-pushed
the
jay/gl-direct-backbuffer-example
branch
from
137ff20 to
94bd182
Compare
There was a problem hiding this comment.
Pull request overview
This PR configures OpenGL contexts in the ThorVG examples to request stencil and multisample buffers, ensuring the direct back-buffer rendering path has the necessary support for stencil operations and antialiasing.
Changes:
- Added SDL GL attributes for stencil buffer (8-bit depth)
- Added SDL GL attributes for multisample antialiasing (4x MSAA)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/MultiCanvas.cpp | Added stencil and MSAA buffer requests to the OpenGL context setup |
| src/Example.h | Added stencil and MSAA buffer requests to the GlWindow OpenGL context setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Request a stencil buffer and multisample buffers for the SDL GL contexts in Example and MultiCanvas so the direct back‑buffer path has the needed stencil/multisample support.
wenjieshen
force-pushed
the
jay/gl-direct-backbuffer-example
branch
from
94bd182 to
701fc4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request a stencil buffer and multisample buffers for the SDL GL contexts in Example and MultiCanvas so the direct back‑buffer path has the needed stencil/multisample support.
This PR should be merged only after thorvg/thorvg#3997 has been merged