Skip to content

Documentation: Inbox migration investigation and full migration plan#163

Merged
SteveDala merged 8 commits intothoth-tech:mainfrom
31Husain31:docs/inbox-migration
Feb 1, 2026
Merged

Documentation: Inbox migration investigation and full migration plan#163
SteveDala merged 8 commits intothoth-tech:mainfrom
31Husain31:docs/inbox-migration

Conversation

@31Husain31
Copy link
Contributor

Hello to all,

This documentation is related to Front End Migration.

I've completed the investigation for the inbox migration task and created a comprehensive plan to finish the migration work.

This PR adds two documentation files to the Front End Migration folder:

  1. INBOX_MIGRATION_INVESTIGATION.md - Documents the current state of the inbox migration. The inbox component has already been migrated to Angular, but the old AngularJS files are still present and need cleanup.

  2. INBOX_FULL_MIGRATION_PLAN.md - Provides a detailed, step-by-step plan to complete the migration, including file cleanup, testing procedures, and README updates.

Key findings:

  • The Angular InboxComponent is already fully functional
  • Old AngularJS inbox.coffee file is still in the codebase
  • Main work needed is cleanup and verification
  • Migration can be completed in a single focused PR

The plan includes detailed testing steps to ensure nothing breaks during the cleanup process.

Thanks,
Husain


Name: Husainuddin Mohammed
ID: 223380186

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for thoth-tech ready!

Name Link
🔨 Latest commit 52ca636
🔍 Latest deploy log https://app.netlify.com/projects/thoth-tech/deploys/697eaf979b72c60008ccaebb
😎 Deploy Preview https://deploy-preview-163--thoth-tech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

YG-GOV
YG-GOV previously requested changes Jan 24, 2026
Copy link
Contributor

@YG-GOV YG-GOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid write-up, the investigation and full migration plan are clear, and it’s helpful seeing exactly what’s already migrated vs what still needs cleanup. The step by step plan and testing notes make the next phase pretty straightforward for whoever picks it up. I can see the Netlify checks are currently failing, so it might be worth checking the deploy logs before merging.

@31Husain31
Copy link
Contributor Author

Hi @YG-GOV, I've fixed the Netlify deployment issues for this PR as well. The frontmatter has been added to the INDBOX MIGRATION files, and the task_Dashboard files have been removed as I realised I mistakenly added extra 2 files (they're in PR #162). All checks are now passing. I believe its safe to merge now.

Copy link

@Rana7xi Rana7xi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation is really helpful for understanding the inbox migration. The investigation does a good job of explaining why the inbox isn’t fully migrated yet, especially the parent state dependencies, which isn’t obvious at first glance. The full migration plan is detailed and makes the order of work very clear.

One small suggestion: it might be useful to add a short “recommended approach” note at the top (e.g. hybrid vs full migration) so readers immediately know which path you’re leaning towards before diving into the details.

Overall, this is solid and should make the next phase of the migration much easier.

Copy link

@rammakablecode rammakablecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve re-reviewed the changes and can confirm:

Frontmatter has been correctly added to the inbox migration docs
The mistakenly included task_Dashboard files have been removed (tracked in PR #162)
and all Netlify and checks are now passing
With the context from #162 and this documnetation clearly capturing the current state of the inbox migration, it provides a long to complete the remaining cleanup

@BrianDangDev
Copy link
Contributor

Check failed. The plan is redundant and doesn’t give me a clear idea of which child component to work on first. At least, include a diagram to visualise the components and keep it 1 page

Copy link

@Rana7xi Rana7xi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation is really helpful for understanding the inbox migration. The investigation does a good job of explaining why the inbox isn’t fully migrated yet, especially the parent state dependencies, which isn’t obvious at first glance. The full migration plan is detailed and makes the order of work very clear.

One small suggestion: it might be useful to add a short “recommended approach” note at the top (e.g. hybrid vs full migration) so readers immediately know which path you’re leaning towards before diving into the details.

Overall, this is solid and should make the next phase of the migration much easier.

@31Husain31
Copy link
Contributor Author

Hi @BrianDangDev,
Thanks for the feedback. You're right - the original plan was too long and unclear.
I've revised both documents as per the feedback.

The plan now clearly shows which components to work on first and why the order matters.

Regarding the failed check, Netlify is successfully passing the checks:
image

Let me know if this addresses your concerns.

@BrianDangDev
Copy link
Contributor

@31Husain31 Linelint check failed
https://github.com/thoth-tech/ThothTech-Documentation-Website/actions/runs/21511928814/job/62081289220?pr=163

can you have a look, seems like it related to the empty space at the bottom of the file

@31Husain31
Copy link
Contributor Author

@BrianDangDev

I believe this should work now. I was told that CI/CD error was occurring due to no blank line at the end of document. I made the changes.

@SteveDala
Copy link
Collaborator

Hi @31Husain31, checking out your files locally reveals that INBOX_FULL_MIGRATION_PLAN.md and INBOX_MIGRATION_INVESTIGATION both have two newlines at the bottom of the file. Linelint (and Markdown) convention is that files end with one (and only one) newline. Solution: remove line 131 from the former, and line 109 from the latter.

@31Husain31
Copy link
Contributor Author

Hi @31Husain31, checking out your files locally reveals that INBOX_FULL_MIGRATION_PLAN.md and INBOX_MIGRATION_INVESTIGATION both have two newlines at the bottom of the file. Linelint (and Markdown) convention is that files end with one (and only one) newline. Solution: remove line 131 from the former, and line 109 from the latter.

Thank you for your review Steven. I have made the necessary changes (same as my PR162)

Copy link
Collaborator

@SteveDala SteveDala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@SteveDala SteveDala dismissed YG-GOV’s stale review February 1, 2026 01:46

Netlify checks are now passing.

@SteveDala SteveDala merged commit b3aecc9 into thoth-tech:main Feb 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments