feat: add UpdateIssueWithOptions #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make clear what it does Signed-off-by: rtweed <RichardoC@users.noreply.github.com>
RichardoC
commented
Feb 19, 2024
| @@ -73,6 +73,19 @@ func testRequestParams(t *testing.T, r *http.Request, want map[string]string) { | |||
|
|
|||
| } | |||
|
|
|||
| func Test_addOptions(t *testing.T) { | |||
| v, err := addOptions("rest/api/2/issue/123", &UpdateQueryOptions{NotifyUsers: false}) | |||
There was a problem hiding this comment.
This test fails without the omitEmpty changes
|
There could be other "default true" fields that have this same issue with omitempty |
chrisnovakovic
added a commit
to chrisnovakovic/go-jira
that referenced
this pull request
Feb 22, 2024
On Jira API endpoints that accept a `notifyUsers` parameter, the value of `notifyUsers` defaults to true if it isn't supplied in the request. When the `UpdateQueryOptions` and `AddWorklogQueryOptions` structs are serialised for inclusion in a request, the `omitempty` tag on the `NotifyUsers` field causes it to be omitted from the serialised string even when it is given an explicit false value, thereby preventing the `notifyUsers` parameter from ever being included in the request. Don't omit `NotifyUsers` from the serialised string when it has a false value, allowing it to be sent in the request. Spotted and fixed by @RichardoC in thought-machine#9 - splitting it out into a separate PR for visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add testing for addOptions to make clear what it does
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: