Skip to content

Commit

Permalink
Silence linter, add comments on _why_ the go.mods are needed
Browse files Browse the repository at this point in the history
  • Loading branch information
Garbett1 committed Jan 6, 2024
1 parent ef275b4 commit fe7df35
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ issues:
- SA5008 # Warns for duplicate struct tags which are meaningful to go-flags
- unslice # This may be useful in some places.
- ifElseChain # Generally don't agree.
- indent-error-flow # Similar to above, seems to be making questionable choices
- appendAssign
- halp # Make misspell be quiet about this.
- exitAfterDefer # Potentially useful but not in any cases it fires right now.
Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ require (
github.com/thought-machine/http-admin v1.1.0
go.uber.org/automaxprocs v1.5.3
gocloud.dev v0.36.0
github.com/golang/snappy v0.0.4 // indirect
github.com/google/go-cmp v0.6.0 // indirect
github.com/golang/snappy v0.0.4 // This is a required dep that Go mod tidy gets rid of. This breaks Please if it gets removed though.
github.com/google/go-cmp v0.6.0 // This is a required dep that Go mod tidy gets rid of. This breaks Please if it gets removed though.
golang.org/x/crypto v0.17.0
golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc
golang.org/x/sync v0.6.0
Expand Down
4 changes: 2 additions & 2 deletions third_party/go/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,7 @@ go_repo(

go_repo(
module = "github.com/bazelbuild/remote-apis",
version = "v0.0.0-20231221155620-d20ae8b97fd3",
version = "v0.0.0-20230411132548-35aee1c4a425",
)

go_repo(
Expand Down Expand Up @@ -3823,7 +3823,7 @@ go_repo(
go_mod_download(
name = "remote-apis-sdks_download",
module = "github.com/peterebden/remote-apis-sdks",
version = "2a9420921957c3485fc59c6cae6adc849591ba48",
version = "v0.0.0-20230518122452-6e5d9d252ff0",
)

go_repo(
Expand Down

0 comments on commit fe7df35

Please sign in to comment.