Feat: Add rate limit to Redis client #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garbett1
commented
Oct 29, 2023
peterebden
approved these changes
Oct 29, 2023
peterebden
reviewed
Oct 29, 2023
Hamishpk
pushed a commit
to Hamishpk/please-servers
that referenced
this pull request
Nov 9, 2023
* Add rate limiting bucket to skip Redis if we have errored often * Puku format * Add x/time to go.mod * Add limit in more locations * Don't mess up the go.mod * Remove the limit on the write * Avoid any leak of the digest proto * Bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some issues with slow downs on workers pulling slowly from Redis.
This PR:
a. Lowers the timeout to 1 second (which is probably reasonable for a Redis command?)
b. Adds a rate limiter in the Redis client that skips the Redis lookups if more than 10 errors have happened in the last 10 seconds.
We only add the rate limit on the read operations, because they are in the critical path.
We want to attempt to keep populating the Redis cache so we can recover to a useful state after the Redis issues.
Not adding configuration just yet, but will make some follow up PRs to add metrics on this.