Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP Cloud profiler support #274

Merged
merged 15 commits into from
Jan 6, 2024
Merged

Conversation

Garbett1
Copy link
Contributor

@Garbett1 Garbett1 commented Jan 6, 2024

Add optional support for sending profiling information to GCP Cloud Profiler.

Copy link
Member

@peterebden peterebden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!

I dunno what the linter is so annoyed about... it seems confused

.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
cli/cli.go Outdated Show resolved Hide resolved
cli/cli.go Show resolved Hide resolved
third_party/proto/resourceusage/BUILD Outdated Show resolved Hide resolved
Copy link
Member

@peterebden peterebden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Garbett1 Garbett1 merged commit a201b81 into thought-machine:master Jan 6, 2024
5 checks passed
Hamishpk pushed a commit to Hamishpk/please-servers that referenced this pull request Mar 7, 2024
…#274)

* Add GCP Cloud profiler support

* Undo a couple of Puku changes

* Update Go and all packages to latest

* Attempt to update to later versions of Go

* Missed the dockerfile

* And latest Docker tags as well

* Try removing systemtoolchain?

* Revert to older image

* Attempt to calm the linter

* Actually revert the SDK override

* Attempt to get around the linter?

* Bump golang CI?

* Fix defer for timer

* Attempt go.mod surgery

* Silence linter, add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants