Remove goroutine #293
Merged
Remove goroutine #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fische
previously approved these changes
Mar 26, 2024
peterebden
force-pushed
the
remove-goroutine
branch
from
fd06773
to
16f23ce
Compare
fische
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler version of #292 ; remove the goroutine and rely on our channels being longer than the number of responses we get (which we think should always be the case)
Should save a bit of CPU too since we're not spinning up so many routines.
Removed the channel-closing stuff so we'll never get a 'send on closed channel', we just bail out of the loop when we get one that's marked Done and let the GC clean it up later.