Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BatchDownload honour maxSize when uploading to redis. #306

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

fische
Copy link
Contributor

@fische fische commented Apr 29, 2024

We're still seeing huge increase in MSET and SET to redis since #303 was landed and deployed. I think it is because BatchDownload does not check the blob size when uploading to redis. This PR should fix this.

@fische fische self-assigned this Apr 29, 2024
Copy link
Contributor

@Hamishpk Hamishpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fische fische merged commit 947353e into thought-machine:master Apr 29, 2024
5 checks passed
@fische fische deleted the redis-honouring-maxsize branch April 29, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants