Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check caches in blobExist in the correct order. #311

Merged
merged 1 commit into from
May 16, 2024

Conversation

fische
Copy link
Contributor

@fische fische commented May 16, 2024

I've just realised blobExists currently checks the existence of the blob in redis before checking it in the in-memory cache. Our redis currently gets hundreds of millions of EXISTS commands everyday, causing high CPU usage and spikes in latency. This will hopefully help with it and should help with the latency of Elan in general.

@fische fische requested review from Hamishpk and Liu-ko May 16, 2024 10:49
@fische fische self-assigned this May 16, 2024
Copy link
Member

@peterebden peterebden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit rusty on this but makes sense!

@fische fische merged commit b6ffca3 into thought-machine:master May 16, 2024
5 checks passed
@fische fische deleted the elan-fix-cache-order branch May 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants