Update golangci-lint and fix various things #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
approved these changes
Oct 25, 2024
fische
approved these changes
Oct 25, 2024
toastwaffle
reviewed
Oct 25, 2024
.github/workflows/golangci-lint.yml
Outdated
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v4 | ||
| with: | ||
| version: v1.57.1 | ||
| version: v1.51.0 |
There was a problem hiding this comment.
Isn't this a downgrade?
There was a problem hiding this comment.
oops! yeah was meant to be the latest version, that's what I have on my machine. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why it started failing (apparently segfaulting?) but updating it seems to fix.
Also the usual round of config changes & some fixes that it found (a couple very relevant to the last PR in fact...)