Skip to content

Allow "ruby file:" syntax in gemfile #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swelther wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow "ruby file:" syntax in gemfile #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2f797a
Allow "ruby file:" syntax in Gemfile
swelther Nov 14, 2024
9a0fd4d
make test pass with all supported ruby versions
swelther Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/appraisal/bundler_dsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ def source(source, &block)
end
end

def ruby(ruby_version)
def ruby(ruby_version = nil, **kwargs)
@ruby_version = ruby_version
@ruby_version = kwargs unless ruby_version
end

def git(source, options = {}, &block)
Expand Down
16 changes: 16 additions & 0 deletions spec/appraisal/gemfile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,4 +440,20 @@
expect(gemfile.load(tmpfile.path)).to include(File.dirname(tmpfile.path))
end
end

it "supports the ruby file: syntax" do
gemfile = Appraisal::Gemfile.new

gemfile.ruby file: ".ruby-version"
gemfile.source "one"

ruby_version = gemfile.instance_variable_get("@ruby_version")
expected = ruby_version.is_a?(String) ? "ruby #{ruby_version.inspect}" : "ruby(#{ruby_version.inspect})"

expect(gemfile.to_s).to eq <<-GEMFILE.strip_heredoc.strip
source "one"

#{expected}
GEMFILE
end
end
Loading