Implement a key-based process table #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hillu
force-pushed
the
fix-proctable
branch
4 times, most recently
from
2cdc8df to
d20f49d
Compare
Processes are now uniquely identified by a ProcessKey instead of process IDs as those may be recycled quickly. Most of the code interfacing with the process table has been pulled into the early part of Coalesce::transform_event that handles SYSCALL messages. The test introduced with threathunters-io#168 now passes. Fixes threathunters-io#146 Performance-wise, this is a slight improvement over current master. This branch: test parse_only ... bench: 20,237,394 ns/iter (+/- 235,818) test parse_serialize ... bench: 27,426,770 ns/iter (+/- 255,343) master (f237694): test parse_only ... bench: 22,737,572 ns/iter (+/- 397,532) test parse_serialize ... bench: 30,010,731 ns/iter (+/- 369,789)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processes are now uniquely identified by a ProcessKey instead of
process IDs as those may be recycled quickly.
Most of the code interfacing with the process table has been pulled
into the early part of Coalesce::transform_event that handles SYSCALL
messages.
The test introduced with #168 now passes.
Fixes #146
Performance-wise, this is a slight improvement over current master.
This branch:
master (f237694):