Skip to content

Commit

Permalink
Fix KTX2Loader TS type to match the JS code (#703)
Browse files Browse the repository at this point in the history
* Fix KTX2Loader TS type to match the JS code

KTX2Loader TS type derives from CompresssedTextureLoader, and overrides its parse method.
The actual JS code derives KTX2Loader from Loader and overrides its load method.
This change will fix this mismatch.

* Update types/three/examples/jsm/loaders/KTX2Loader.d.ts

Co-authored-by: Nathan Bierema <nbierema@gmail.com>

* Removed load method from KTX2Loader.

---------

Co-authored-by: Nathan Bierema <nbierema@gmail.com>
  • Loading branch information
svignaud and Methuselah96 authored Dec 11, 2023
1 parent bd59dfd commit a16eabe
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions types/three/examples/jsm/loaders/KTX2Loader.d.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
import { LoadingManager, CompressedTextureLoader, CompressedTexture, WebGLRenderer } from '../../../src/Three.js';
import { LoadingManager, Loader, CompressedTexture, WebGLRenderer } from '../../../src/Three.js';
import WebGPURenderer from '../renderers/webgpu/WebGPURenderer.js';

export class KTX2Loader extends CompressedTextureLoader {
export class KTX2Loader extends Loader<CompressedTexture> {
constructor(manager?: LoadingManager);

setTranscoderPath(path: string): KTX2Loader;
setWorkerLimit(limit: number): KTX2Loader;
detectSupport(renderer: WebGLRenderer | WebGPURenderer): KTX2Loader;
dispose(): KTX2Loader;

parse(
buffer: ArrayBuffer,
onLoad: (texture: CompressedTexture) => void,
onError?: (event: ErrorEvent) => void,
): KTX2Loader;
}

0 comments on commit a16eabe

Please sign in to comment.