Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 16 byte namespaces, introduce wrapper type for pallet parameter #115

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Dec 13, 2023

Also updates the transaction validation logic to reject transactions with invalid namespaces.

Closes #12

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@rphmeier rphmeier marked this pull request as ready for review December 13, 2023 20:35
@rphmeier rphmeier changed the title add namespace type to primitives Use 16 byte namespaces and introduce a wrapper type for the parameter Dec 13, 2023
@rphmeier rphmeier changed the title Use 16 byte namespaces and introduce a wrapper type for the parameter Use 16 byte namespaces, introduce wrapper type for pallet parameter Dec 13, 2023
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good!

sugondat-chain/pallets/blobs/src/namespace_param.rs Outdated Show resolved Hide resolved
sugondat-chain/pallets/blobs/src/namespace_param.rs Outdated Show resolved Hide resolved
sugondat-chain/pallets/blobs/src/namespace_param.rs Outdated Show resolved Hide resolved
@rphmeier rphmeier merged commit 40d6b1a into main Dec 15, 2023
0 of 3 checks passed
@rphmeier rphmeier deleted the rh_namespace_type branch December 15, 2023 00:52
pepyakin added a commit that referenced this pull request Dec 15, 2023
pepyakin added a commit that referenced this pull request Dec 15, 2023
rphmeier pushed a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine Namespace ID size
2 participants