Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override default bytes ser/de. #131

Merged
merged 2 commits into from
Dec 15, 2023
Merged

override default bytes ser/de. #131

merged 2 commits into from
Dec 15, 2023

Conversation

pepyakin
Copy link
Contributor

Serialize the byte vectors and arrays in hex format.
Extract serialization into its own crate (there is a reason why I did not go for a blanket primitives crate).
Rollkit uses base64 serialization, so it's logic also moved into that crate.

Closes #117

Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel like we have written this piece of code for every project using RPC in the last few years

Base automatically changed from pep-follow-up-namespace-type-extension to main December 15, 2023 16:38
@rphmeier rphmeier merged commit ecc5c3a into main Dec 15, 2023
2 checks passed
@rphmeier rphmeier deleted the pep-pretty-serde branch December 15, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shim: Avoid bare serialization of byte buffers and other non-standard json types
2 participants