xtask: make testing cwd independent #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
gabriele-0201
force-pushed
the
gab_xtask_cwd_independent
branch
from
a5ad9ef to
5e0d41e
Compare
|
Merged the wrong PR, oops. |
pepyakin
reviewed
Feb 20, 2024
| let _ = log_file | ||
| .write(format!("{}\n", description).as_bytes()) | ||
| .map_err(|e| warn!("Error writing into {log_path}, error: {e}")); | ||
| .map_err(|e| warn!("Error writing into {log_path}, error: {e}",)); |
There was a problem hiding this comment.
trailing ,
as well as below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only non-trivial thing in this PR should be how 'log_path' is specified in the CLI. I propose handling it in the following way: if 'log_path' is relative, it will be made absolute relative to the root project_path and not to where the command is actually called. Absolute paths would not been changed
closes #232