fix(trickfs): nonempty rmdir #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 6, 2025
rphmeier
approved these changes
Feb 7, 2025
pepyakin
force-pushed
the
pep-trickfs-macos-fix
branch
from
6415348 to
ac07bbf
Compare
pepyakin
force-pushed
the
pep-fix-trickfs-rmdir-nonempty
branch
from
afed08c to
f6e2b34
Compare
pepyakin
changed the base branch from
pep-trickfs-macos-fix
to
graphite-base/785
Actually, we can expect no entries at all when removing a dir. But let's check that anyway and return a special error reserved for such cases.
pepyakin
force-pushed
the
pep-fix-trickfs-rmdir-nonempty
branch
from
f6e2b34 to
9c6462c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, we can expect no entries at all when removing a dir. But let's check
that anyway and return a special error reserved for such cases.