refactor: define hasher traits in nomt-core hasher module and feature-gate #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rphmeier
force-pushed
the
rh-hasher-trait-refactor
branch
from
ce68e7e to
6cf78d9
Compare
rphmeier
force-pushed
the
rh-node-hasher-labeling-abstraction
branch
from
3d45b1e to
bdc1a2d
Compare
rphmeier
force-pushed
the
rh-hasher-trait-refactor
branch
2 times, most recently
from
6837243 to
e1f3d23
Compare
pepyakin
approved these changes
Feb 7, 2025
| node[0] |= 0b10000000; | ||
| } | ||
|
|
||
| pub fn unset_msb(node: &mut Node) { |
pepyakin
changed the base branch from
rh-node-hasher-labeling-abstraction
to
graphite-base/787
pepyakin
force-pushed
the
rh-hasher-trait-refactor
branch
from
e1f3d23 to
7115fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor moves the definition of hashing traits into
nomt-core::Hasher. It also exposes a simpleBinaryHashtrait that can be used to implement any binary hash with our typical MSB labeling scheme.Blake3Hash is no longer exported from the NOMT crate root, but instead the
nomt_core::hashermodule is re-exported.Also adds a feature-gated sha2 hasher.