feat(torture): unify rollback and rollback crash #792
+45
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pepyakin
approved these changes
Feb 12, 2025
torture/src/supervisor/workload.rs
Outdated
| self.ensure_snapshot_validity(rr).await?; | ||
| Ok(()) | ||
| } | ||
| // Udpate RequestResponse, the agent could have been respawned. |
gabriele-0201
force-pushed
the
gm_torture_rollback_support_enospc
branch
from
d704d59 to
bc7ff0c
Compare
The unification of the two has the side effect of handling ENOSPC errors also for rollbacks that are expected to crash.
gabriele-0201
force-pushed
the
gm_torture_rollback_support_enospc
branch
from
bc7ff0c to
262e8da
Compare
gabriele-0201
force-pushed
the
gm_torture_unify_rollback_and_rollback_crash
branch
from
1885e40 to
0385977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unification of the two has the side effect of handling
ENOSPC errors also for rollbacks that are expected to crash.
Closes THR-110