Rector: investigation into CI integration

app/Actions/ProcessProperty/OnTheMarketAction.php

@@ -10,7 +10,8 @@
 
 class OnTheMarketAction extends ProviderAction implements RespondsToProviderUrlInterface
 {
-    const PROVIDER_NAME = 'OnTheMarket';
+    /** @var string */
+    public const PROVIDER_NAME = 'OnTheMarket';
 
     protected Crawler $crawler;
 

app/Actions/ProcessProperty/RightmoveAction.php

@@ -10,7 +10,8 @@
 
 class RightmoveAction extends ProviderAction implements RespondsToProviderUrlInterface
 {
-    const PROVIDER_NAME = 'Rightmove';
+    /** @var string */
+    public const PROVIDER_NAME = 'Rightmove';
 
     protected Crawler $crawler;
 
@@ -67,7 +68,7 @@ protected function processAmenityNames(): array
             return [];
         }
 
-        return $amenities_crawler->each(function (Crawler $node) {
+        return $amenities_crawler->each(function (Crawler $node): string {
             return Str::limit($node->text(), 255);
         });
     }

app/Actions/ProcessProperty/Utils.php

@@ -4,6 +4,7 @@
 
 final class Utils
 {
+    /** @var string[] */
     public const PROVIDER_ACTIONS = [
         OnTheMarketAction::class,
         RightmoveAction::class,

app/Actions/ProcessProperty/ZooplaAction.php

@@ -10,7 +10,8 @@
 
 class ZooplaAction extends ProviderAction implements RespondsToProviderUrlInterface
 {
-    const PROVIDER_NAME = 'Zoopla';
+    /** @var string */
+    public const PROVIDER_NAME = 'Zoopla';
 
     protected Crawler $crawler;
 
@@ -67,7 +68,7 @@ protected function processAmenityNames(): array
             return [];
         }
 
-        return $amenities_crawler->each(function (Crawler $node) {
+        return $amenities_crawler->each(function (Crawler $node): string {
             return Str::limit($node->text(), 255);
         });
     }

app/Console/Kernel.php

@@ -22,7 +22,7 @@ class Kernel extends ConsoleKernel
      * @param  \Illuminate\Console\Scheduling\Schedule  $schedule
      * @return void
      */
-    protected function schedule(Schedule $schedule)
+    protected function schedule(Schedule $schedule): void
     {
         // $schedule->command('inspire')->hourly();
     }
@@ -32,7 +32,7 @@ protected function schedule(Schedule $schedule)
      *
      * @return void
      */
-    protected function commands()
+    protected function commands(): void
     {
         $this->load(__DIR__.'/Commands');
 

app/Events/CommentStored.php

@@ -10,7 +10,9 @@
 
 class CommentStored
 {
-    use Dispatchable, InteractsWithSockets, SerializesModels;
+    use Dispatchable;
+    use InteractsWithSockets;
+    use SerializesModels;
 
     /**
      * Create a new event instance.

app/Events/PropertyStored.php

@@ -3,17 +3,15 @@
 namespace App\Events;
 
 use App\Models\Property;
-use Illuminate\Broadcasting\Channel;
 use Illuminate\Broadcasting\InteractsWithSockets;
-use Illuminate\Broadcasting\PresenceChannel;
-use Illuminate\Broadcasting\PrivateChannel;
-use Illuminate\Contracts\Broadcasting\ShouldBroadcast;
 use Illuminate\Foundation\Events\Dispatchable;
 use Illuminate\Queue\SerializesModels;
 
 class PropertyStored
 {
-    use Dispatchable, InteractsWithSockets, SerializesModels;
+    use Dispatchable;
+    use InteractsWithSockets;
+    use SerializesModels;
 
     /**
      * Create a new event instance.

app/Exceptions/Handler.php

@@ -31,7 +31,7 @@ class Handler extends ExceptionHandler
      *
      * @return void
      */
-    public function register()
+    public function register(): void
     {
     }
 }

app/Http/Controllers/Auth/ConfirmablePasswordController.php

@@ -13,10 +13,9 @@ class ConfirmablePasswordController extends Controller
     /**
      * Show the confirm password view.
      *
-     * @param  \Illuminate\Http\Request  $request
      * @return \Illuminate\View\View
      */
-    public function show(Request $request)
+    public function show()
     {
         return view('auth.confirm-password');
     }

app/Http/Controllers/Controller.php

@@ -9,5 +9,7 @@
 
 class Controller extends BaseController
 {
-    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;
+    use AuthorizesRequests;
+    use DispatchesJobs;
+    use ValidatesRequests;
 }

app/Http/Middleware/TrustHosts.php

@@ -11,7 +11,7 @@ class TrustHosts extends Middleware
      *
      * @return array
      */
-    public function hosts()
+    public function hosts(): array
     {
         return [
             $this->allSubdomainsOfApplicationUrl(),

app/Http/Requests/Auth/LoginRequest.php

@@ -11,22 +11,12 @@
 
 class LoginRequest extends FormRequest
 {
-    /**
-     * Determine if the user is authorized to make this request.
-     *
-     * @return bool
-     */
-    public function authorize()
-    {
-        return true;
-    }
-
     /**
      * Get the validation rules that apply to the request.
      *
      * @return array
      */
-    public function rules()
+    public function rules(): array
     {
         return [
             'email' => 'required|string|email',
@@ -38,10 +28,9 @@ public function rules()
      * Attempt to authenticate the request's credentials.
      *
      * @return void
-     *
      * @throws \Illuminate\Validation\ValidationException
      */
-    public function authenticate()
+    public function authenticate(): void
     {
         $this->ensureIsNotRateLimited();
 
@@ -60,10 +49,9 @@ public function authenticate()
      * Ensure the login request is not rate limited.
      *
      * @return void
-     *
      * @throws \Illuminate\Validation\ValidationException
      */
-    public function ensureIsNotRateLimited()
+    public function ensureIsNotRateLimited(): void
     {
         if (! RateLimiter::tooManyAttempts($this->throttleKey(), 5)) {
             return;
@@ -86,7 +74,7 @@ public function ensureIsNotRateLimited()
      *
      * @return string
      */
-    public function throttleKey()
+    public function throttleKey(): string
     {
         return Str::lower($this->input('email')).'|'.$this->ip();
     }

app/Jobs/ProcessPropertyUrlJob.php

@@ -16,7 +16,10 @@
 
 class ProcessPropertyUrlJob implements ShouldQueue
 {
-    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
+    use Dispatchable;
+    use InteractsWithQueue;
+    use Queueable;
+    use SerializesModels;
 
     public function __construct(
         protected Property $property,
@@ -28,7 +31,7 @@ public function __construct(
      *
      * @return void
      */
-    public function handle()
+    public function handle(): void
     {
         // If URL differ, we assume it has changed before processing the job
         // and is being dealt with, and return

app/Listeners/SendCommentStoredNotificationListener.php

@@ -16,7 +16,7 @@ class SendCommentStoredNotificationListener
      * @param \App\Events\CommentStored $event
      * @return void
      */
-    public function handle(CommentStored $event)
+    public function handle(CommentStored $event): void
     {
         $comment = $event->getComment();
         $property = $event->getProperty();
@@ -28,7 +28,7 @@ public function handle(CommentStored $event)
             ->where('user_id', '<>', $creator->id)
             ->pluck('user')
             ->filter()
-            ->filter(static function (User $recipient) {
+            ->filter(static function (User $recipient): bool {
                 return $recipient->notification_preferences->where(
                     'type_id',
                     config('app.notification_types.new_comment_id')
@@ -38,7 +38,7 @@ public function handle(CommentStored $event)
                 $comment,
                 $property,
                 $creator,
-            ) {
+            ): void {
                 $recipient->notify(
                     new CommentStoredNotification($comment, $property, $creator)
                 );

app/Listeners/SendPropertyStoredNotificationListener.php

@@ -16,7 +16,7 @@ class SendPropertyStoredNotificationListener
      * @param \App\Events\PropertyStored $event
      * @return void
      */
-    public function handle(PropertyStored $event)
+    public function handle(PropertyStored $event): void
     {
         $property = $event->getProperty();
         $creator = $property->user;
@@ -27,7 +27,7 @@ public function handle(PropertyStored $event)
             ->where('user_id', '<>', $creator->id)
             ->pluck('user')
             ->filter()
-            ->filter(static function (User $recipient) {
+            ->filter(static function (User $recipient): bool {
                 return $recipient->notification_preferences->where(
                     'type_id',
                     config('app.notification_types.new_property_id')

app/Notifications/CommentStoredNotification.php

@@ -31,10 +31,9 @@ public function __construct(
     /**
      * Get the notification's delivery channels.
      *
-     * @param mixed $notifiable
      * @return array
      */
-    public function via($notifiable)
+    public function via(): array
     {
         return ['mail'];
     }
@@ -45,7 +44,7 @@ public function via($notifiable)
      * @param mixed $notifiable
      * @return \Illuminate\Notifications\Messages\MailMessage
      */
-    public function toMail($notifiable)
+    public function toMail($notifiable): MailMessage
     {
         return (new MailMessage)
             ->subject($this->creator->name.' Has Added A Comment')

app/Notifications/InviteUserNotification.php

@@ -25,10 +25,9 @@ public function __construct(
     /**
      * Get the notification's delivery channels.
      *
-     * @param mixed $notifiable
      * @return array
      */
-    public function via($notifiable)
+    public function via(): array
     {
         return ['mail'];
     }
@@ -39,7 +38,7 @@ public function via($notifiable)
      * @param mixed $notifiable
      * @return \Illuminate\Notifications\Messages\MailMessage
      */
-    public function toMail($notifiable)
+    public function toMail($notifiable): MailMessage
     {
         return (new MailMessage)
             ->subject(

app/Notifications/PropertyStoredNotification.php

@@ -28,10 +28,9 @@ public function __construct(
     /**
      * Get the notification's delivery channels.
      *
-     * @param mixed $notifiable
      * @return array
      */
-    public function via($notifiable)
+    public function via(): array
     {
         return ['mail'];
     }
@@ -42,7 +41,7 @@ public function via($notifiable)
      * @param mixed $notifiable
      * @return \Illuminate\Notifications\Messages\MailMessage
      */
-    public function toMail($notifiable)
+    public function toMail($notifiable): MailMessage
     {
         return (new MailMessage)
             ->subject($this->creator->name.' Has Added A New Property')
@@ -55,10 +54,7 @@ public function toMail($notifiable)
                 'View On Website',
                 route('properties.show', $this->property)
             )
-            ->line(
-                'You can let your group know what you think, '.
-                'by leaving a preference or a comment'
-            )
+            ->line('You can let your group know what you think, by leaving a preference or a comment.')
             ->salutation('Regards,');
     }
 }