Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with rack-test and at_exit hook issues #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

conflict with rack-test and at_exit hook issues #34

wants to merge 2 commits into from

Conversation

lucashungaro
Copy link
Contributor

I was trying to setup Riot + rack-test in a Rails app and got name conflicts with the options method, so I renamed it to option_set.

The second commit is to prevent an issue where a Rake::TestTask always reports a failure, despite the tests passing. I'm not sure I understood what you were trying to accomplish there, so feel free to fix it in a different way, of course. :)

@achiurizo
Copy link
Contributor

i've pulled in your "conflict with rack-test" change here: 4008ad1. For the at_exit hook change, i was unable to reproduce the error. I've encountered this error before but @jaknowlden and I recall that the code that exists there was to address this issue specifically. Thanks for the commit regardless. I'll keep an eye out and continue to see if this issue still pops up. I'm in the #riot irc room if you want to continue diving in this issue further. Thanks!

@lucashungaro
Copy link
Contributor Author

Ok, I'll reinstall Ruby from scratch and try again.

@lucashungaro
Copy link
Contributor Author

Ok, reinstalled Ruby 1.9.2 and tried again. Got the same errors.

@achiurizo
Copy link
Contributor

Ok, i'll take a look again.

@achiurizo
Copy link
Contributor

@lucashungaro is the rake test failure still an issue? @jaknowlden any ideas?

@gus
Copy link
Member

gus commented Aug 25, 2011

I'll take a look this afternoon.

Justin Knowlden

On Wednesday, August 24, 2011 at 11:36 PM, achiu wrote:

@lucashungaro is the rake test failure still an issue? @jaknowlden any ideas?

Reply to this email directly or view it on GitHub:
#34 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants