Fix the /components/overview/ page
#943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thumbprint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for thumbprint-gatsby canceled.
|
We proxy some routes from Next.js to Gatsby, but we had it set as `beforeFiles`. This caused `/components/overview` to fail because the glob in one of the rewrites was catching it. Switching to `afterFiles` tells Next.js to only proxy if the page doesn't exist in Next.js.
danoc
force-pushed
the
daniel/fix-components-overview
branch
from
8a82a51
to
612f451
Compare
lavelle
approved these changes
Jul 12, 2023
egoens
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We proxy some routes from Next.js to Gatsby, but we had it set as
beforeFiles. This caused/components/overviewto fail because the glob in one of the rewrites was catching it. Switching toafterFilestells Next.js to only proxy if the page doesn't exist in Next.js.