Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed types for the Image component #944

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fixed types for the Image component #944

merged 2 commits into from
Jul 31, 2023

Conversation

danoc
Copy link
Member

@danoc danoc commented Jul 14, 2023

We spread props on the picture element, but our types don't reflect that.

Fixes #940.

@danoc
Fixed types for the Image component
0d06b74 
We spread `props` on the `picture` element, but our types don't reflect that.

Fixes #940.
@danoc danoc requested review from lavelle and dcapo July 14, 2023 18:33
@netlify
Copy link

netlify bot commented Jul 14, 2023 •
edited
Loading

❌ Deploy Preview for thumbprint-gatsby failed.

Name Link
🔨 Latest commit dc613d3
🔍 Latest deploy log https://app.netlify.com/sites/thumbprint-gatsby/deploys/64baa9c9f33cf00008356f3e

@netlify
Copy link

netlify bot commented Jul 14, 2023 •
edited
Loading

✅ Deploy Preview for thumbprint canceled.

Name Link
🔨 Latest commit dc613d3
🔍 Latest deploy log https://app.netlify.com/sites/thumbprint/deploys/64baa9c982f5eb0008408b60

@danoc danoc mentioned this pull request Jul 14, 2023
Closed
@danoc
Copy link
Member Author

danoc commented Jul 21, 2023

@lavelle, @dcapo — PTAL

@danoc danoc merged commit 25561ca into master Jul 31, 2023
5 of 9 checks passed
@danoc danoc deleted the daniel/image-fix branch July 31, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavelle lavelle lavelle approved these changes

@dcapo dcapo Awaiting requested review from dcapo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Image> does not support the style prop in TypeScript
3 participants
@danoc @lavelle @egoens