Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acutally fix types for Button component mouse and focus events #979

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

danoc
Copy link
Member

@danoc danoc commented Apr 3, 2024

I didn't scroll far enough in the file last time. Turns out there were a few places to edit. This should probably be refactored so that it's not duplicated, but it's possible that the duplication was needed for the auto-generated docs to work.

@danoc danoc requested a review from michaeldrob April 3, 2024 20:06
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for thumbprint ready!

Name Link
🔨 Latest commit 9684442
🔍 Latest deploy log https://app.netlify.com/sites/thumbprint/deploys/660db6f1f343f000078112c4
😎 Deploy Preview https://deploy-preview-979--thumbprint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for thumbprint-gatsby canceled.

Name Link
🔨 Latest commit 9684442
🔍 Latest deploy log https://app.netlify.com/sites/thumbprint-gatsby/deploys/660db6f1e3c27f0007a740cd

@danoc danoc merged commit eeecac7 into master Apr 3, 2024
8 of 9 checks passed
@danoc danoc deleted the daniel/fix-types branch April 3, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants