Prevent the server from 500'ing when subscriber.timezone == None #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependency, and error out a booking request if the owner does not have a timezone set.
…cessed at the time of the booking.
devmount
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the core issue of #247 but doesn't display the error messages.
Spent a good while doing a short term refactor of the booking modal to show error details, but after a lunch and a think, I believe we should probably just handle that next in #248.
But the main fix here is that the subscriber's timezone on user login if the timezone is None. I also caught a few issues like the booking view completely dying if a single remote calendar request fails. I realize it's not ideal, but we shouldn't block the form.