Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending request email after booking from schedule, and move email background tasks #258

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

MelissaAutumn
Copy link
Member

Fixes #251

Might want to give emails a double check, I have and everything seems to be working.

FastAPI has a feature that lets you queue up tasks to happen after the request has been sent. Obviously we shouldn't use too often, but emails is a good use-case for it.

https://fastapi.tiangolo.com/tutorial/background-tasks/

@MelissaAutumn MelissaAutumn added the l10n update A string has been added or needs updating label Feb 5, 2024
@MelissaAutumn MelissaAutumn self-assigned this Feb 5, 2024
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for organizing email stuff so well, it works on my end too 👏🏻 I added the German translation and improved the *.ftl files some more by using existing placeholders for app name and footer at places.

@MelissaAutumn MelissaAutumn merged commit 9a1c0b8 into main Feb 6, 2024
2 checks passed
@MelissaAutumn MelissaAutumn deleted the features/251-pending-email branch February 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n update A string has been added or needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-Booking Request Confirmation Email
2 participants