-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable code coverage analysis locally and in CI #830
Conversation
e95c299
to
83fa29b
Compare
83fa29b
to
786fe75
Compare
786fe75
to
7651ef0
Compare
7651ef0
to
c59a692
Compare
c59a692
to
e7308e4
Compare
e7308e4
to
929ba0b
Compare
b06eb10
to
2572ac6
Compare
1bb6309
to
6f0215c
Compare
6f0215c
to
55549e7
Compare
Got the code coverage report working both locally and in CI now \o/ Here's a link to a GHA validate-backend CI run and you can see the code coverage report: Note: I am setting the ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor things but nothing thats not a 2 second fix.
Do we have a way to view the coveeage level from the pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you Rob!
@@ -137,19 +137,30 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v5 | |||
with: | |||
python-version: '3.12' | |||
python-version: '3.13' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This should fix some issues we had due to different python versions 👍🏻
There are some third-party github actions that allow just that - publish your code coverage results to a PR comment, i.e.: https://github.com/marketplace/actions/python-coverage However I'm not sure if we want to use third-party GHA that aren't certified by GitHub because of security; also it requires a separate github token also. Maybe something to consider in the future though! |
Enable code coverage analysis (for the backend tests) both when running the tests locally as well as in CI. See the updated README file for more information.
Thanks @MelissaAutumn as you already had the groundwork for this in the repo! I am just updating the README and enabling the code coverage tool to run in CI.