Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline icons in invitation email #857

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix inline icons in invitation email #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93b9501
🔨 Fix inline icons
devmount Feb 6, 2025
26b893f
📜 Fix markdown linter issues
devmount Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ When running locally and looking into code coverage further you may wish to gene
```bash
coverage html
```

Then open the resulting `backend/htmlcov/index.html` file in your browser and you can click down into individual source files to see which statements were (and were not) executed during the test session.

Note that the code coverage report will contain the coverage generated for all the tests that were ran in your pytest session; so if you want to measure the code coverage for a subset of tests just provide the test path on the `coverage run -m pytest` command as you normally would, then generate the coverage report(s).


## Database Migrations

To generate a database migration, bash into a running backend container and run:
Expand Down
4 changes: 2 additions & 2 deletions backend/src/appointment/controller/mailer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ def html(self):
duration=self.duration,
# Image cids
tbpro_logo_cid=self._attachments()[0].filename,
calendar_icon_cid=self._attachments()[1].filename,
clock_icon_cid=self._attachments()[2].filename,
calendar_icon_cid=self._attachments()[2].filename,
clock_icon_cid=self._attachments()[3].filename,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe switch to a dict, or change the BaseBookingMail so that inline images are separate from other attachments.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with both! Can you put that into a follow-up ticket? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#860 🎉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

)


Expand Down