Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for DeleteItem #17

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Add types for DeleteItem #17

merged 7 commits into from
Nov 12, 2024

Conversation

babolivier
Copy link
Member

@babolivier babolivier commented Oct 23, 2024 •
edited
Loading

Implements the types necessary to support the DeleteItem operation: https://learn.microsoft.com/en-us/exchange/client-developer/web-service-reference/deleteitem-operation

leftmostcat
leftmostcat approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@leftmostcat leftmostcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks about docs, nothing functional or blocking.

src/types/delete_item.rs Outdated Show resolved Hide resolved
src/types/delete_item.rs Outdated Show resolved Hide resolved
src/types/delete_item.rs Outdated Show resolved Hide resolved
leftmostcat
leftmostcat approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@leftmostcat leftmostcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still just documentation nitpicks, feel free to merge whenever you feel it's appropriate.

src/types/delete_item.rs Outdated Show resolved Hide resolved
src/types/delete_item.rs Outdated Show resolved Hide resolved
src/types/delete_item.rs Show resolved Hide resolved
@babolivier babolivier merged commit 89a9614 into main Nov 12, 2024
1 check passed
@babolivier babolivier deleted the babolivier/message_deletion branch November 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leftmostcat leftmostcat leftmostcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babolivier @leftmostcat