Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing soap:Fault in error responses #4

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

leftmostcat
Copy link
Collaborator

Exchange will return a soap:Fault when there is an error at the request level (rather than at the operation level). We want to return this as an error which can be inspected by the consumer.

@leftmostcat leftmostcat marked this pull request as ready for review April 12, 2024 18:49
Copy link
Contributor

@ikeycode ikeycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ikeycode ikeycode merged commit 1c627f1 into main Apr 15, 2024
2 checks passed
@leftmostcat leftmostcat deleted the fault-parsing branch April 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants