Merge pull request #927 from thunderstore-io/cyberstorm-nonnullable-p…

…ackage-icon Cyberstorm API: packages are always guaranteed to have an icon image
thunderstore-io · Dec 5, 2023 · 7367421 · 7367421
2 parents f43b743 + d1b7386
commit 7367421
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/django/thunderstore/api/cyberstorm/serializers/package.py b/django/thunderstore/api/cyberstorm/serializers/package.py
@@ -20,7 +20,7 @@ class CyberstormPackagePreviewSerializer(serializers.Serializer):
         max_length=PackageVersion._meta.get_field("description").max_length,
     )
     download_count = serializers.IntegerField(min_value=0)
-    icon_url = serializers.CharField(allow_null=True)
+    icon_url = serializers.CharField()
     is_deprecated = serializers.BooleanField()
     is_nsfw = serializers.BooleanField()
     is_pinned = serializers.BooleanField()

diff --git a/django/thunderstore/api/cyberstorm/views/packages.py b/django/thunderstore/api/cyberstorm/views/packages.py
@@ -229,7 +229,7 @@ def _get_packages_dicts(self, package_page: Page):
                     "community_identifier": community_id,
                     "description": p.latest.description,
                     "download_count": p.download_count,
-                    "icon_url": p.latest.icon.url if bool(p.latest.icon) else None,
+                    "icon_url": p.latest.icon.url,
                     "is_deprecated": p.is_deprecated,
                     "is_nsfw": listing.has_nsfw_content,
                     "is_pinned": p.is_pinned,