Add DynamicHTML options and endpoints for Cyberstorm #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oksamies
force-pushed
the
05-24-Add_DynamicHTML_options_and_endpoints_for_Cyberstorm
branch
from
3066f62
to
c613e5a
Compare
MythicManiac
requested changes
May 27, 2024
Comment on lines
+22
to
+25
| if ( | ||
| self.kwargs["placement"].startswith("cyberstorm_") | ||
| and self.kwargs["placement"] in DynamicPlacement.options() | ||
| ): |
There was a problem hiding this comment.
no need to check for the cyberstorm prefix, just check if the kwarg is a valid option. also invert the if clause.
| is_active=True, | ||
| ).order_by("ordering") | ||
| if len(dynamic_htmls) != 0: | ||
| return {"dynamic_htmls": [escapejs(dh.content) for dh in dynamic_htmls]} |
There was a problem hiding this comment.
why are we escaping? shouldn't be necessary here, in fact it's probably the opposite of what we want
| dynamic_htmls = serializers.ListField(child=serializers.CharField()) | ||
|
|
||
|
|
||
| class DynamicHTMLAPIView(CyberstormAutoSchemaMixin, RetrieveAPIView): |
There was a problem hiding this comment.
There's no reason to use the RetrieveAPIView base class when you're not returning a db model instance. Use the GenericAPIView instead and just implement the get method on it.
Comment on lines
+22
to
+26
| path( | ||
| "dynamichtml/<str:placement>/", | ||
| DynamicHTMLAPIView.as_view(), | ||
| name="cyberstorm.dynamichtml", | ||
| ), |
There was a problem hiding this comment.
Perhaps we should have an API view which returns all active placements, rather than one view per placement ID? Would make it only require 1 request on the clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.