Add Nimbus background image to community model #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -66,7 +66,7 @@ def test_api_cyberstorm_community_list_get_success( | |||
| assert results[index]["identifier"] == c.identifier | |||
| assert results[index]["total_download_count"] == c.aggregated.download_count | |||
| assert results[index]["total_package_count"] == c.aggregated.package_count | |||
| assert results[index]["background_image_url"] == c.background_image_url | |||
| assert results[index]["nimbus_background_image_url"] == c.background_image_url | |||
There was a problem hiding this comment.
The assertion is comparing against the wrong property. The left side checks nimbus_background_image_url but the right side uses background_image_url. To fix this, change to:
assert results[index]["nimbus_background_image_url"] == c.nimbus_background_image_urlSpotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Oksamies
force-pushed
the
11-12-add_nimbus_background_image_to_community_model
branch
from
42bf528
to
e2d73e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.