Add tests to UserDeleteView endpoint

django/thunderstore/api/cyberstorm/tests/test_user.py

@@ -0,0 +1,64 @@
+import json
+
+import pytest
+from django.contrib.auth import get_user_model
+from rest_framework.test import APIClient
+
+from thunderstore.core.types import UserType
+from thunderstore.repository.factories import UserFactory
+
+User = get_user_model()
+
+
+@pytest.mark.django_db
+def test_user_delete__when_deleting_own_account__succeeds(
+    api_client: APIClient,
+    user: UserType,
+):
+    api_client.force_authenticate(user)
+    response = api_client.post(
+        "/api/cyberstorm/current-user/delete/",
+        json.dumps({"verification": user.username}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 200
+
+    with pytest.raises(User.DoesNotExist) as e:
+        User.objects.get(pk=user.pk)
+    assert "User matching query does not exist." in str(e.value)
+
+
+@pytest.mark.django_db
+def test_user_delete__when_deleting_own_account__fails_because_user_is_not_authenticated(
+    api_client: APIClient,
+    user: UserType,
+):
+    response = api_client.post(
+        "/api/cyberstorm/current-user/delete/",
+        json.dumps({"verification": user.username}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 401
+    response_json = response.json()
+    assert response_json["detail"] == "Authentication credentials were not provided."
+    assert User.objects.filter(pk=user.pk).count() == 1
+
+
+@pytest.mark.django_db
+def test_user_delete__when_missing_verification_parameter__fails(
+    api_client: APIClient,
+    user: UserType,
+):
+    api_client.force_authenticate(user)
+    response = api_client.post(
+        "/api/cyberstorm/current-user/delete/",
+        json.dumps({"verification": "TotallyNotCorrectUsername"}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 400
+    response_json = response.json()
+    assert "Invalid verification" in response_json["verification"]
+    assert User.objects.filter(pk=user.pk).count() == 1

django/thunderstore/api/cyberstorm/views/user.py

@@ -0,0 +1,40 @@
+from django.http import HttpRequest
+from rest_framework import serializers
+from rest_framework.exceptions import ValidationError
+from rest_framework.permissions import IsAuthenticated
+from rest_framework.response import Response
+from rest_framework.views import APIView
+
+from thunderstore.api.utils import conditional_swagger_auto_schema
+from thunderstore.social.views import DeleteAccountForm
+
+
+class CyberstormUserDeleteRequestSerialiazer(serializers.Serializer):
+    verification = serializers.CharField()
+
+
+class CyberstormUserDeleteResponseSerialiazer(serializers.Serializer):
+    username = serializers.CharField()
+
+
+class UserDeleteAPIView(APIView):
+    permission_classes = [IsAuthenticated]
+
+    @conditional_swagger_auto_schema(
+        request_body=CyberstormUserDeleteRequestSerialiazer,
+        responses={200: CyberstormUserDeleteResponseSerialiazer},
+        operation_id="cyberstorm.current-user.delete",
+        tags=["cyberstorm"],
+    )
+    def post(self, request: HttpRequest):
+        serializer = CyberstormUserDeleteRequestSerialiazer(data=request.data)
+        serializer.is_valid(raise_exception=True)
+        form = DeleteAccountForm(
+            user=request.user,
+            data=serializer.validated_data,
+        )
+        if form.is_valid():
+            form.delete_user()
+            return Response()
+        else:
+            raise ValidationError(form.errors)

django/thunderstore/api/urls.py

@@ -16,6 +16,7 @@
     TeamMembersAPIView,
     TeamServiceAccountsAPIView,
 )
+from thunderstore.api.cyberstorm.views.user import UserDeleteAPIView
 
 cyberstorm_urls = [
     path(
@@ -101,4 +102,9 @@
         PackageVersionsAPIView.as_view(),
         name="cyberstorm.package.versions",
     ),
+    path(
+        "current-user/delete/",
+        UserDeleteAPIView.as_view(),
+        name="cyberstorm.current-user.delete",
+    ),
 ]

django/thunderstore/social/views.py

@@ -49,6 +49,9 @@ def clean_verification(self):
             raise forms.ValidationError("Invalid verification")
         return data
 
+    def delete_user(self):
+        self.user.delete()
+
 
 class DeleteAccountView(SettingsViewMixin, RequireAuthenticationMixin, FormView):
     template_name = "settings/delete_account.html"
@@ -66,5 +69,5 @@ def get_form_kwargs(self, *args, **kwargs):
         return kwargs
 
     def form_valid(self, form):
-        self.request.user.delete()
+        form.delete_user()
         return super().form_valid(form)