Favicon fixing #1199
Merged
Favicon fixing #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give favicons backgrounds so they don't look jarring against white. Change some meta colors to use brand colors.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
x753
force-pushed
the
favicon-fixing
branch
3 times, most recently
from
7bf3f93
to
58f906d
Compare
Meta tags should be above link tags. Also slightly adjust indent.
x753
force-pushed
the
favicon-fixing
branch
from
58f906d
to
9eb3d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new favicon is too bright and looks bad against a white background. This PR fixes that by giving favicons backgrounds.
Also adjusts some meta colors which may affect stuff like the browser the site was opened in.