Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with standard pip installation methods #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jrouly
Copy link

@jrouly jrouly commented Jan 28, 2022

Because setup.py exists within a subfolder (src) and this package is not published on PyPi, it's impossible to install from git with package managers like poetry.

Moving setup.py to the top level and exposing the package instead of src makes this package more compatible.

@ChristianSch
Copy link

until this is merged, if at all, you can use this:

pip3 install 'openne @ git+https://github.com/thunlp/OpenNE.git@master#subdirectory=src'

@jrouly
Copy link
Author

jrouly commented Jul 19, 2023

@helloxcq @zzy14 @eustomaqua @Freyr-Wings @skeletondyh Any chance of getting this merged? We've been maintaining an internal fork with this change for over a year now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants