Fix panic when different pan IDs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvdveld
force-pushed
the
fix-issue-29
branch
from
a1dcde7 to
7180e03
Compare
When the PAN IDs are equal, then PAN ID compression is used, removing the source PAN ID from the frame. The same behaviour was observed when the PAN IDs were different, which is incorrect. This commit fixes the issue by only compressing the source PAN ID when the PAN IDs are equal.
thvdveld
force-pushed
the
fix-issue-29
branch
from
7180e03 to
1f235c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 75.58% 75.86% +0.27%
==========================================
Files 36 36
Lines 5403 5423 +20
==========================================
+ Hits 4084 4114 +30
+ Misses 1319 1309 -10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PAN IDs are equal, then PAN ID compression is used, removing the source PAN ID from the frame. The same behaviour was observed when the PAN IDs were different, which is incorrect. This commit fixes the issue by only compressing the source PAN ID when the PAN IDs are equal.
Fixes #29.