Enhance support for TSCH IEs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvdveld
reviewed
Jan 17, 2025
dot15d4-frame/src/tests/mod.rs
Outdated
Comment on lines
162
to
195
| 0x40, 0xeb, 0xcd, 0xab, 0xff, 0xff, 0x01, 0x00, 0x01, 0x00, 0x01, 0x00, 0x01, 0x00, | ||
| 0x00, 0x3f, 0x11, 0x88, 0x06, 0x1a, 0x0e, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x1c, | ||
| 0x00, 0x01, 0xc8, 0x00, 0x01, 0x1b, 0x00 | ||
| ], | ||
| 64, 235, 205, 171, 255, 255, 1, 0, 1, 0, 1, 0, 1, 0, 0, 63, 55, 136, 6, 26, 17, 0, 0, | ||
| 0, 0, 0, 25, 28, 1, 8, 7, 128, 0, 72, 8, 252, 3, 32, 3, 232, 3, 152, 8, 144, 1, 192, 0, | ||
| 96, 9, 160, 16, 16, 39, 1, 200, 0, 15, 27, 1, 0, 17, 0, 2, 0, 0, 1, 0, 6, 1, 0, 2, 0, | ||
| 7 | ||
| ] |
There was a problem hiding this comment.
Could you use hex formatting for the values for consistency?
dot15d4-frame/src/repr/ie/nested.rs
Outdated
Comment on lines
237
to
242
| { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Maybe here is a good place to also log the error or something? This might help us in the future.
dot15d4-frame/src/ie/nested.rs
Outdated
Comment on lines
921
to
927
|
|
||
| /// Return the content of the TSCH slotframe and link IE. | ||
| pub fn content_mut(&mut self) -> &mut [u8] { | ||
| &mut self.data.as_mut()[1..] | ||
| } |
There was a problem hiding this comment.
I think content_mut should be implemented for T: AsRef<[u8]> + AsMut<[u8]> + ?Sized. Can you take a look at an implementation of payload_mut.
|
I did some modifications to |
Support for optional timeslot timings with variable values width (2/3 byte). Support Parsing/emitting/repr
Support for representation/emitting/parsing of the following : - TSCH Slotframe and Link Nested IE - Slotframe descriptor - Link Information Support for fuzzing of the new representations
- Add TODO for supporting customizable size for Vec - Add new impl block for getting mutable content for ?Sized - Adapted dot15d4-cat for new options
jeremydub
force-pushed
the
enhance-support-tsch-ies
branch
from
98af939 to
b17bbf6
Compare
|
Great ! I pushed changes, it should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of enhancing the support of IE used by TSCH.
Enhance support for TSCH Tmeslot IE
Enhance support for TSCH Slotframe and Link Nested IE with support for representation/emitting/parsing of the following :
Support for fuzzing of the new representations.
Update test 'emit_enhanced_beacon'.
Update dot15d4-cat with new IEs.