-
Notifications
You must be signed in to change notification settings - Fork 309
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(compiler): provide ngcc-jest-processor util
Jest parallel mode doesn't allow `ngcc` to run. The only way to run `ngcc` with Jest is invoking `ngcc` directly in `jest.config.js`. Because Jest reads `jest.config.js` only once before running tests, running `ngcc` is possible with it
- Loading branch information
Showing
9 changed files
with
70 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports = require('./build/compiler/ngcc-jest-processor'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/** | ||
* Mainly copied from https://github.com/angular/angular-cli/blob/master/packages/ngtools/webpack/src/ngcc_processor.ts | ||
* and adjusted to work with Jest | ||
*/ | ||
import { spawnSync } from 'child_process'; | ||
import { existsSync } from 'fs'; | ||
import { dirname, join } from 'path'; | ||
|
||
function findNodeModulesDirectory(startPoint: string): string { | ||
let current = startPoint; | ||
while (dirname(current) !== current) { | ||
const nodePath = join(current, 'node_modules'); | ||
if (existsSync(nodePath)) { | ||
return nodePath; | ||
} | ||
|
||
current = dirname(current); | ||
} | ||
|
||
throw new Error(`Cannot locate the 'node_modules' directory.`); | ||
} | ||
|
||
if (!existsSync(join(process.cwd(), 'angular.json'))) { | ||
throw new Error('ngcc-jest-processor should be only run from root directory'); | ||
} | ||
|
||
// We spawn instead of using the API because: | ||
// - NGCC Async uses clustering which is problematic when used via the API which means | ||
// that we cannot setup multiple cluster masters with different options. | ||
// - We will not be able to have concurrent builds otherwise Ex: App-Shell, | ||
// as NGCC will create a lock file for both builds and it will cause builds to fails. | ||
const { status, error } = spawnSync( | ||
process.execPath, | ||
[ | ||
require.resolve('@angular/compiler-cli/ngcc/main-ngcc.js'), | ||
'--source' /** basePath */, | ||
findNodeModulesDirectory(process.cwd()), | ||
'--properties' /** propertiesToConsider */, | ||
/** | ||
* There are various properties: fesm2015, fesm5, es2015, esm2015, esm5, main, module, browser to choose from. | ||
* Currently Jest requires `commonjs` so we only need to ask `ngcc` to produce `umd` outputs. Later when switching | ||
* to ESM, we can change to different properties to produce ESM outputs. | ||
*/ | ||
...['main'], | ||
'--first-only' /** compileAllFormats */, | ||
'false', // make sure that `ngcc` runs on subfolders as well | ||
'--async', | ||
], | ||
{ | ||
stdio: ['inherit', process.stderr, process.stderr], | ||
}, | ||
); | ||
if (status !== 0) { | ||
const errorMessage = error?.message ?? ''; | ||
|
||
throw new Error(errorMessage + `NGCC failed${errorMessage ? ', see above' : ''}.`); | ||
} |