Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust PlayLog test setup #2

Merged
merged 10 commits into from
May 29, 2024
Prev Previous commit
Next Next commit
Add extension to compare asset positions accounting for agreed error …
…margin
stoyicker committed May 29, 2024

Verified

This commit was signed with the committer’s verified signature.
stoyicker Jorge Antonio Díaz-Benito Soriano
commit 78cea01cea5323aef563cb37e4511fbc73204394
Original file line number Diff line number Diff line change
@@ -2,8 +2,9 @@ package com.tidal.sdk.player.playlog

import android.app.Application
import androidx.test.platform.app.InstrumentationRegistry
import assertk.Assert
import assertk.assertThat
import assertk.assertions.isBetween
import assertk.assertions.isCloseTo
import assertk.assertions.isEqualTo
import com.google.gson.Gson
import com.google.gson.JsonObject
@@ -176,8 +177,10 @@ class PlayLogTest {
eq(ConsentCategory.NECESSARY),
argThat {
with(Gson().fromJson(this, JsonObject::class.java)["payload"].asJsonObject) {
assertThat(get("startAssetPosition").asDouble).isEqualTo(0.0)
assertThat(get("endAssetPosition").asDouble).isBetween(5.0, 5.1)
// https://github.com/androidx/media/issues/1252
assertThat(get("startAssetPosition").asDouble).isAssetPositionEqualTo(0.0)
kgrevehagen marked this conversation as resolved.
Show resolved Hide resolved
// https://github.com/androidx/media/issues/1253
assertThat(get("endAssetPosition").asDouble).isAssetPositionEqualTo(5.065)
assertThat(get("actualProductId").asString).isEqualTo(mediaProduct.productId)
assertThat(get("sourceType")?.asString).isEqualTo(mediaProduct.sourceType)
assertThat(get("sourceId")?.asString).isEqualTo(mediaProduct.sourceId)
@@ -188,4 +191,8 @@ class PlayLogTest {
eq(emptyMap()),
)
}

private fun Assert<Double>.isAssetPositionEqualTo(targetPosition: Double) = run {
isCloseTo(targetPosition, 0.5)
}
}