Skip to content

Conversation

@bballdavis
Copy link

Added Rivian Logo, both as an image asset (Base64) as well as the related support functions for selection.

Added Rivian Logo, both as an image asset (Base64) as well as the related support functions for selection.
@bballdavis bballdavis requested a review from drudge as a code owner January 26, 2026 18:35
Copilot AI review requested due to automatic review settings January 26, 2026 18:35
@tidbyt
Copy link

tidbyt bot commented Jan 26, 2026

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (IngmarStein) does not match the PR author (bballdavis)

@tidbyt-bot
Copy link

tidbyt-bot commented Jan 26, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bballdavis
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Rivian brand support to the EV logo selection feature by introducing the Rivian logo as a base64-encoded image asset and updating the related support functions.

Changes:

  • Added RIVIAN_LOGO_18x18 base64-encoded image constant
  • Updated get_ev_logo() function to return Rivian logo when "RIVIAN" is selected
  • Added "Rivian" option to the EV Brand dropdown in the schema, positioned alphabetically between Renault and Seat

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1097 to +1100
schema.Option(
display = "Rivian",
value = "RIVIAN",
),
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md documentation lists available EV brands (lines 224-234) but does not include Rivian. Since this PR adds Rivian as a new brand option, the documentation should be updated to include it in the list. Rivian should be added between "Renault" and "Seat" to maintain alphabetical order.

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants