-
Notifications
You must be signed in to change notification settings - Fork 764
Add Rivian logo and update related functions #3170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added Rivian Logo, both as an image asset (Base64) as well as the related support functions for selection.
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Rivian brand support to the EV logo selection feature by introducing the Rivian logo as a base64-encoded image asset and updating the related support functions.
Changes:
- Added RIVIAN_LOGO_18x18 base64-encoded image constant
- Updated get_ev_logo() function to return Rivian logo when "RIVIAN" is selected
- Added "Rivian" option to the EV Brand dropdown in the schema, positioned alphabetically between Renault and Seat
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| schema.Option( | ||
| display = "Rivian", | ||
| value = "RIVIAN", | ||
| ), |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.md documentation lists available EV brands (lines 224-234) but does not include Rivian. Since this PR adds Rivian as a new brand option, the documentation should be updated to include it in the list. Rivian should be added between "Renault" and "Seat" to maintain alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the readme.
Added Rivian Logo, both as an image asset (Base64) as well as the related support functions for selection.