Skip to content

Add Dev mode button#500

Merged
hansemannn merged 2 commits intotidev:masterfrom
m1ga:devtools
Oct 7, 2022
Merged

Add Dev mode button#500
hansemannn merged 2 commits intotidev:masterfrom
m1ga:devtools

Conversation

@m1ga
Copy link
Contributor

@m1ga m1ga commented Sep 12, 2021

Screenshot_20210912_171343

Adding a button to toggle dev-mode. Instead of trying to open the devtools right away (like #80) it will just attach --debug-host localhost:8989 and you have to open the devtools yourself.

@build
Copy link
Contributor

build commented Sep 12, 2021

Messages
📖

✅ All tests are passing
Nice one! All 34 tests are passing.

Generated by 🚫 dangerJS against 1c55246

Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this but can understand the desire to make debugging simpler in Atom.

Would the expectation be that a developer would open devtools manually either in Chrome or in Atom? I wonder if we could also include the same translation layer we use in VS Code to allow Chrome to work with iOS.

I'm not sure however what we could do to correctly handle things like source mapping as that requires some intervention in the VS Code debugger

@m1ga m1ga changed the title Wip: Add Dev mode button Add Dev mode button Sep 20, 2021
@m1ga
Copy link
Contributor Author

m1ga commented Sep 20, 2021

It's a first step to #80 There it will start a devtools tab but you had to use a custom args parameter to start the debug mode. This PR adds the button. And even without #80 you could use it in a separate chrome instance. But of course the big goal is to make #80 work again

@hansemannn hansemannn merged commit 76405ff into tidev:master Oct 7, 2022
@m1ga m1ga deleted the devtools branch October 7, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants