Skip to content

as.list() methods for S7 classes #6699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 4, 2025
Merged

as.list() methods for S7 classes #6699

merged 8 commits into from
Dec 4, 2025
+97 −13

Conversation

@teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Oct 15, 2025

This PR aims to fix #6695.

Generally, the as.list() methods come in 2 flavours based on class structure.

  1. For property-based classes, like ggplot/ggplot_built/element_* classes, we return the properties.
  2. For list-based classes, like mapping/theme/labels, we return the list data.

thomasp85
thomasp85 approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand
resolve merge conflict
f216c0a 
Merge branch 'main' into S7_as_list

# Conflicts:
#	tests/testthat/_snaps/theme.md
#	tests/testthat/test-theme.R
@teunbrand
add news bullet
7c0c2a5
@teunbrand teunbrand merged commit 6ea6ead into tidyverse:main Dec 4, 2025
13 checks passed
@teunbrand teunbrand deleted the S7_as_list branch December 4, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

as.list() methods for S7 classes

2 participants

@teunbrand @thomasp85