Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Improvements: Objects and NPCs with occlusion culling #148

Merged
merged 19 commits into from
Jun 18, 2024
Merged

Performance Improvements: Objects and NPCs with occlusion culling #148

merged 19 commits into from
Jun 18, 2024

Conversation

pijaro
Copy link
Contributor

@pijaro pijaro commented Jun 20, 2023

No description provided.

pijaro added 12 commits June 19, 2023 14:30
@pijaro
Route traffic simulator
126f76f 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Blue material for ego npc
2f2fd26 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Reworked ego hook for traffic sim,
f9f30ed 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Improves parameter tooltips for traffic simulators
b173234 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Objects and NPCs improvements
26014a1 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Merge branch 'main' into feature/objects_and_npcs_improvements
f2dee45
@pijaro
Light intensity updates
501c3fc 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Cleaned up unecessary scene
9ccefaa 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Updated buildings prefab
40373b9 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Cleanup
71d4e40 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Barriers separated
9e5b784 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro
Fix driver LOD for some NPC vehicles
bc17fb6 
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro pijaro changed the title Performance Improvements: Objects and NPCs Performance Improvements: Objects and NPCs with occlusion culling Jun 20, 2023
mackierx111
mackierx111 requested changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pijaro
I could not get the AutowareSimulation.unity scene to work correctly. Could you please tell me how to do a correct review?

@pijaro
Copy link
Contributor Author

pijaro commented Jul 10, 2023

I think that you are using the old Shinjuku unitypackage. Please remove the current one and use the new one 🙇

@mackierx111
Copy link
Collaborator

@pijaro
Sorry for neglecting this pull request. Can you please resolve the conflict so I can review this pull request again and merge it into the main branch?

@lchojnack
Merge branch 'main' into feature/objects_and_npcs_improvements
1d4c512 
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack
Copy link
Contributor

@mackierx111
I've resolved conflicts. The PR is ready for review

@mackierx111
Copy link
Collaborator

@lchojnack
Can you please provide me with a download link for Shinjuku with occlusion culling applied?

@lchojnack
feat: add occlusion culling to Autoware Simulation scene
81c0795 
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack
Copy link
Contributor

@mackierx111
The unitypackage is here
I've noticed that after resolving the conflicts, the occlusion culling was not enabled. I've enebled it.

@lchojnack
fix: add fps text to scenario simulator scene
a96011f 
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@pijaro pijaro mentioned this pull request Jun 7, 2024
Open
@mackierx111
Copy link
Collaborator

@lchojnack
I imported the Japan_Tokyo_Nishishinjuku_improved.unitypackage and ran the AutowareSimulation scene.
However, some objects in nishishinjuku (Tree, fence, etc.) are not displayed. Could you please check?
Also, I would like to see the scene conflicts eliminated.

Sorry it took so much time to review this pull reqeust. But I want to check it carefully.

image

@mackierx111 mackierx111 marked this pull request as draft June 11, 2024 09:05
@mackierx111
Copy link
Collaborator

Change to draft until the above comments are resolved.

@lchojnack
Merge branch 'main' into feature/objects_and_npcs_improvements
a20437a 
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack
feat(prefab): update Nishishinjuku RandomTraffic
9d8c9b3 
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack
Copy link
Contributor

@mackierx111
I've resolved the conflict and updated the Nishishinjuku RandomTraffic prefab
I've also prepared the new unitypackage which is a unitypackge used so far with shrubs and trees improvements which comes with this PR.
The unitypackage is available here

@lchojnack lchojnack marked this pull request as ready for review June 12, 2024 13:14
mackierx111
mackierx111 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
We plan to release v1.2.2 as soon as possible. At that time, I will also distribute the new Nishi-Shinjuku environment unitypackage. (Japan_Tokyo_Nishishinjuku_v2.unitypackage)

@mackierx111 mackierx111 merged commit 3c50775 into main Jun 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pijaro @mackierx111 @lchojnack